fix: close logging-channels when closing channels #5592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kornes <28986062+kornes@users.noreply.github.com>
pajlada
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a continuation of #4928 (or rather: I took the changes and applied them to the current code). Channels are now removed from the logger when they're destructed. If the app is being destroyed, they're not unregistered (they will be "unregistered" when the singleton is destructed). When a channel is destroyed (e.g. due to the user closing all tabs with the channel), its
LoggingChannel, which holds the file handle, is destroyed. This also causes a stop-logging message to be inserted. Previously, that message was only appended when the app was closed. I'd argue that was a bug, since there weren't any messages logged.I couldn't help myself but rename
ChatterChatterstoChannelChatters, add a space to the stop message, and resolve some clang-tidy suggestions.